Migrating to junit5 #232
Merged
Migrating to junit5 #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import statement was changed. Also the way of handling exception was also updated
Contributor
Author
Owner
|
Looks worthwhile, thanks! I'll review soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
============================================
- Coverage 99.53% 98.39% -1.15%
- Complexity 171 173 +2
============================================
Files 10 10
Lines 428 435 +7
Branches 75 77 +2
============================================
+ Hits 426 428 +2
- Misses 1 3 +2
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
vyshakputhusseri
commented
Nov 1, 2024
Comment on lines
24
to
44
| Constructor<T> constructor; | ||
| try { | ||
| constructor = cls.getDeclaredConstructor(); | ||
| } catch (NoSuchMethodException e1) { | ||
| throw new RuntimeException(e1); | ||
| } catch (SecurityException e1) { | ||
| throw new RuntimeException(e1); | ||
| } | ||
| assertTrue(Modifier.isPrivate(constructor.getModifiers())); | ||
| constructor.setAccessible(true); | ||
| try { | ||
| constructor.newInstance(); | ||
| } catch (InstantiationException e) { | ||
| throw new RuntimeException(e); | ||
| } catch (IllegalAccessException e) { | ||
| throw new RuntimeException(e); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new RuntimeException(e); | ||
| } catch (InvocationTargetException e) { | ||
| throw new RuntimeException(e); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I missed this case.
Can I make change to this method?
Contributor
Author
There was a problem hiding this comment.
@davidmoten That one missed change was also done. You can proceed with the review.
Owner
|
oops, forgot to squash, I'll squash now |
Closed
Owner
|
squashed, thanks for the contribution @puthusseri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to upgraded the code base to junit5 to get new features for unit testing. Below are the steps, I followed :
Steps: