Skip to content

Conversation

hsheth2
Copy link
Contributor

@hsheth2 hsheth2 commented Feb 2, 2023

When building feast from source (which happens on M1 machines), setuptools (or maybe distutils/pip?) complained that the versions were invalid. This was fixed upstream in feast by feast-dev/feast#3471, and so we want to take advantage of these changes.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

When building feast from source (which happens on M1 machines),
setuptools (or maybe distutil/pip?) complained that the versions were
invalid. This was fixed upstream in feast by feast-dev/feast#3471,
and so we want to take advantage of these changes.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 2, 2023
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit e3af616 into datahub-project:master Feb 2, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2 hsheth2 deleted the feast-issue branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants