Optimize the push method when the limit (n) parameter is used #11559
+53
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files + 2 15 suites +2 4h 8m 33s ⏱️ + 40m 7s Results for commit f3465ce. ± Comparison against base commit 4814464. ♻️ This comment has been updated with latest results. |
…of the docs of the push method
github-actions
bot
added
the
needs attention
a-holm
reviewed
Mar 30, 2025
|
|
||
|
|
||
| def push(array, n, axis): | ||
| def push(array, n, axis, method="sequential"): |
There was a problem hiding this comment.
perhaps update the docstring to explain the method parameter and the behavior related to n.
github-actions
bot
removed
the
needs attention
github-actions
bot
added
the
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files@phofl here is the PR to optimize the push method based on the discussion that we had in this PR.
The main problem that I found was that there is no nanlast method on Dask, should I copy the logic from Xarray to this repository? or is it okay for now to use the sequential method by default to avoid adding the nanlast?