Skip to content

Move logic to package:icu4x #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Move logic to package:icu4x #993

wants to merge 16 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jul 10, 2025

Merge after unicode-org/icu4x#6739

Remove the build and link hook portions which are now in package:icu4x - this means that the code copying can be deleted as well.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:intl4x labels Jul 10, 2025
Copy link

github-actions bot commented Jul 10, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x Breaking 0.12.2 0.13.0-wip 0.13.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl4x/hook/link.dart 💔 Not covered
pkgs/intl4x/lib/src/case_mapping/case_mapping_4x.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_4x.dart 💚 77 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_4x.dart 💚 75 %
pkgs/intl4x/lib/src/display_names/display_names_4x.dart 💚 69 %
pkgs/intl4x/lib/src/list_format/list_format_4x.dart 💚 100 %
pkgs/intl4x/lib/src/locale/locale_4x.dart 💚 43 %
pkgs/intl4x/lib/src/number_format/number_format_4x.dart 💚 93 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_4x.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@robertbastian robertbastian marked this pull request as ready for review August 13, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants