Skip to content

[cupertino_http]: Switch to ffigen 19.1.0 #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

brianquinlan
Copy link
Collaborator

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Aug 18, 2025
Copy link

github-actions bot commented Aug 18, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:cronet_http 1.5.0 already published at pub.dev
package:cupertino_http 2.4.0-wip WIP (no publish necessary)
package:http 1.5.0 already published at pub.dev
package:http2 3.0.0 ready to publish http2-v3.0.0
package:http_multi_server 3.2.2 already published at pub.dev
package:http_parser 4.1.2 already published at pub.dev
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 1.0.1 already published at pub.dev
package:web_socket_channel 3.0.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Aug 18, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cupertino_http Breaking 2.3.0 2.4.0-wip 3.0.0
Got "2.4.0-wip" expected >= "3.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/example/integration_test/client_profile_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/http_url_response_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/mutable_url_request_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/ns_error_client_exception.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_cache_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_request_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_response_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_configuration_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_delegate_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_task_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/utils_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/web_socket_conformance_test.dart 💔 Not covered
pkgs/cupertino_http/example/integration_test/web_socket_test.dart 💔 Not covered
pkgs/cupertino_http/example/lib/book.dart 💔 Not covered
pkgs/cupertino_http/example/lib/main.dart 💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_api.dart 💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_client.dart 💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_web_socket.dart 💔 Not covered
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart 💔 Not covered
pkgs/cupertino_http/lib/src/utils.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
cupertino_http ncb.NSURLCache cupertino_api.dart::URLCache
native_cupertino_bindings.dart::NSURLCache::getSharedURLCache
native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value
native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity
native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1
native_cupertino_bindings.dart::NSURLCache::init
native_cupertino_bindings.dart::NSURLCache::new$
native_cupertino_bindings.dart::NSURLCache::allocWithZone
native_cupertino_bindings.dart::NSURLCache::alloc
native_cupertino_bindings.dart::NSURLCache::self$1
native_cupertino_bindings.dart::NSURLCache::retain
native_cupertino_bindings.dart::NSURLCache::autorelease
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
cupertino_http NSURLRequest native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request
native_cupertino_bindings.dart::NSURLRequest::requestWithURL
native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1
native_cupertino_bindings.dart::NSURLRequest::initWithURL
native_cupertino_bindings.dart::NSURLRequest::initWithURL$1
native_cupertino_bindings.dart::NSURLRequest::init
native_cupertino_bindings.dart::NSURLRequest::new$
native_cupertino_bindings.dart::NSURLRequest::allocWithZone
native_cupertino_bindings.dart::NSURLRequest::alloc
native_cupertino_bindings.dart::NSURLRequest::self$1
native_cupertino_bindings.dart::NSURLRequest::retain
native_cupertino_bindings.dart::NSURLRequest::autorelease
native_cupertino_bindings.dart::NSURLRequest::initWithCoder
native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest
native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request
cupertino_http NSURLRequestAttribution native_cupertino_bindings.dart::NSURLRequest::attribution
native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper
native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser
native_cupertino_bindings.dart::NSURLRequestAttribution::values
native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue
cupertino_http NSCachedURLResponse native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest
native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse
cupertino_http ncb.NSURLSessionDelegate cupertino_api.dart::URLSession::delegate
cupertino_http ncb.NSURLSessionConfiguration cupertino_api.dart::URLSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier
native_cupertino_bindings.dart::NSURLSessionConfiguration::init
native_cupertino_bindings.dart::NSURLSessionConfiguration::new$
native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone
native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc
native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1
native_cupertino_bindings.dart::NSURLSessionConfiguration::retain
native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease
cupertino_http SSLProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12
native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13
native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll
native_cupertino_bindings.dart::SSLProtocol::values
native_cupertino_bindings.dart::SSLProtocol::fromValue
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
cupertino_http tls_protocol_version_t native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12
native_cupertino_bindings.dart::tls_protocol_version_t::values
native_cupertino_bindings.dart::tls_protocol_version_t::fromValue
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
cupertino_http NSHTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
cupertino_http NSURLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant