Skip to content

Conversation

brianquinlan
Copy link
Collaborator

@brianquinlan brianquinlan commented Nov 5, 2024


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:http2 2.3.1 ready to publish http2-v2.3.1
package:cronet_http 1.3.3-wip WIP (no publish necessary)
package:cupertino_http 2.0.1-wip WIP (no publish necessary)
package:http 1.2.3-wip WIP (no publish necessary)
package:http_parser 4.1.1 already published at pub.dev
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 0.1.6 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Nov 5, 2024

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/lib/src/cupertino_api.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/cronet_http/lib/src/jni/jni_bindings.dart
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart
pkgs/http/example/main.dart
pkgs/http2/test/src/flowcontrol/mocks.mocks.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/ok_http/lib/src/jni/bindings.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart

@brianquinlan brianquinlan merged commit 0544e1f into dart-lang:master Nov 5, 2024
31 of 34 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 7, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/4b62792..1156cfe):
  1156cfe4  2024-11-06  Jacob MacDonald  Use `values` iterator  and `update` in map equality/hash (dart-lang/core#718)
  9ab5a189  2024-11-05  Jacob MacDonald  add a basic benchmark for DeepCollectionEquality (dart-lang/core#717)
  9e379158  2024-11-05  Jonas Finnemann Jensen  Introduce `IterableMapEntryExtension` for use with `Map.entries`. (dart-lang/core#715)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5168f81..24c2a96):
  24c2a966  2024-11-04  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/dartdoc#3922)

http (https://github.com/dart-lang/http/compare/8db0d0a..03ced4d):
  03ced4d  2024-11-06  Brian Quinlan  Upgrade flutter_http_example to cupertino_http (dart-lang/http#1393)
  df59bac  2024-11-05  Brian Quinlan  Release package:cupertino_http 2.0.1 (dart-lang/http#1400)
  0544e1f  2024-11-05  Brian Quinlan  Fix a bug where cupertino_http did not work on iOS<17. (dart-lang/http#1399)

sse (https://github.com/dart-lang/sse/compare/1b02011..befbd6d):
  befbd6d  2024-11-04  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-archive/sse#118)

Change-Id: I2b4ebfe2f56f9478c7e89cd2d3e50485ae44caa0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393943
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.0.0 incompatible with iOS 15 & 16
2 participants