Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compiling darktable code with LLVM 20 fails with the following error:
We can't use
NULLhere. The problem is that in this case the code ends up being included from a C++ source file (exif.cc), and in C++ (unlike plain C)NULLis defined as simply0or0LL(which is an integer constant, but not a pointer type), while in plain C it is defined as((void *)0).LLVM 20 starts flagging this as a warning (which becomes an error in our build process), forcing sentinel to be a null pointer, not just a null value.
The need for sentinel to be a pointer type is documented in https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Common-Function-Attributes.html#index-sentinel-function-attribute: