Skip to content

wf Worker should only close clients it has initialized #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

wf Worker should only close clients it has initialized #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions workflow/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,29 @@ func NewWorker(opts ...workerOption) (*WorkflowWorker, error) {
return nil, errors.New("failed to load options")
}
}
var daprClient dapr.Client
var err error
if options.daprClient == nil {
daprClient, err = dapr.NewClient()
} else {

var (
daprClient dapr.Client
err error
closeFunc = func() {}
)

if options.daprClient != nil {
daprClient = options.daprClient
} else {
if daprClient, err = dapr.NewClient(); err != nil {
return nil, err
}

closeFunc = daprClient.Close
}
if err != nil {
return nil, err
}

grpcConn := daprClient.GrpcClientConn()

return &WorkflowWorker{
tasks: task.NewTaskRegistry(),
client: durabletaskclient.NewTaskHubGrpcClient(grpcConn, backend.DefaultLogger()),
close: daprClient.Close,
close: closeFunc,
}, nil
}

Expand Down