[service/http]switch from Gorilla Mux to Chi #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacky CSL <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 69.41% 69.36% -0.06%
==========================================
Files 30 30
Lines 2253 2249 -4
==========================================
- Hits 1564 1560 -4
Misses 597 597
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I think this is a smart decision. Was going to submit PR for the same. |
daixiang0
approved these changes
Mar 16, 2023
Contributor
Author
|
@daixiang0 Thanks for the approval. Is it possible to re-run the CI scan? |
Member
|
You need update commit to trigger it, I do not find a button to re-run. |
Member
|
@shubham1172 I do not see re-run button in the CI, how to enable it? |
Member
|
@yaron2 please re-run the CI then we can get it. |
Member
|
No license issue, skip re-run CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Switch from Gorilla Mux to Chi as Gorilla Mux is no longer maintained.
The APIs remained fairly similar.
Link to tracking Issue:
[#344 ]
Testing:
Regression test are passed.
Documentation:
N/A