Remove existing guidance on health endpoint #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
alicejgibbons
approved these changes
Aug 29, 2025
Contributor
alicejgibbons
left a comment
alicejgibbons
left a comment
There was a problem hiding this comment.
Small verbiage changes!
| - For a full guide on output bindings visit [How-To: Use bindings]({{% ref howto-bindings.md %}}). | ||
|
|
||
| ### Retrieve secrets | ||
| Prior to retrieving secrets, it's important that the outbound channel be registered and ready or the SDK will be unable |
Contributor
There was a problem hiding this comment.
Suggested change
| Prior to retrieving secrets, it's important that the outbound channel be registered and ready or the SDK will be unable | |
| Prior to retrieving secrets, it's important that the "outbound" channel to Daprd be registered and ready or the SDK will be unable |
Contributor
Author
There was a problem hiding this comment.
Outbound is from daprd to the application, not application to daprd.
| ### Retrieve secrets | ||
| Prior to retrieving secrets, it's important that the outbound channel be registered and ready or the SDK will be unable | ||
| to communicate bidirectionally with the Dapr sidecar. The SDK provides a helper method intended to be used for this | ||
| purpose called `CheckOutboundHealthAsync`. This isn't referring to outbound from the SDK to the runtime, so much as |
Contributor
There was a problem hiding this comment.
Suggested change
| purpose called `CheckOutboundHealthAsync`. This isn't referring to outbound from the SDK to the runtime, so much as | |
| purpose called `CheckOutboundHealthAsync`. In this case "outbound" refers to the bi-directional communication channel established by Daprd reaching out to the client application using the SDK. |
Contributor
Author
There was a problem hiding this comment.
This isn't accurate - outbound is from Daprd to the client application. Some of the SDKs have a bidirectional channel (e.g. workflows, cryptography), but this isn't that. This is a one-way channel for Daprd to push messages out to the client application without necessitating that the client poll anything.
| Prior to retrieving secrets, it's important that the outbound channel be registered and ready or the SDK will be unable | ||
| to communicate bidirectionally with the Dapr sidecar. The SDK provides a helper method intended to be used for this | ||
| purpose called `CheckOutboundHealthAsync`. This isn't referring to outbound from the SDK to the runtime, so much as | ||
| outbound from the Dapr runtime back into the client application using the SDK. |
Contributor
There was a problem hiding this comment.
Suggested change
| outbound from the Dapr runtime back into the client application using the SDK. |
Contributor
Author
There was a problem hiding this comment.
See previous (also, all these line breaks are there because my IDE doesn't wrap anything, so I manually wrap them at ~180 characters a line).
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote secrets management and health method sections
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: