Skip to content

fix: Allow Mobile Scroll During Message Stream #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2023
Merged

fix: Allow Mobile Scroll During Message Stream #984

merged 3 commits into from
Sep 22, 2023

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Sep 22, 2023 •
edited
Loading

Summary

Closes #983.

  • Title. Added onTouchMove which I wasn't as familiar with when first implemented.
  • Took the opportunity to optimize all the related scrolling logic as best as I could see.
  • Enables auto-scrolling again if the scroll to bottom button was clicked
  • Fixed a type issue with IconProps

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested manually on mobile

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila mentioned this pull request Sep 22, 2023
Closed
1 task
@danny-avila danny-avila merged commit 7c0379b into main Sep 22, 2023
@danny-avila danny-avila deleted the mobile-scroll branch September 22, 2023 20:16
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
@danny-avila
fix: Allow Mobile Scroll During Message Stream (danny-avila#984)
c305d0b 
* fix(Icon/types): pick types from TMessage and TConversation

* refactor: make abortScroll a global recoil state and change props/types for useScrollToRef

* refactor(Message): invoke abort setter onTouchMove and onWheel, refactor(Messages): remove redundancy, reset abortScroll when scroll button is clicked
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
@danny-avila
fix: Allow Mobile Scroll During Message Stream (danny-avila#984)
57875cb 
* fix(Icon/types): pick types from TMessage and TConversation

* refactor: make abortScroll a global recoil state and change props/types for useScrollToRef

* refactor(Message): invoke abort setter onTouchMove and onWheel, refactor(Messages): remove redundancy, reset abortScroll when scroll button is clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Auto-scroll on mobile browser prevents reading GPT reply until it's completed
1 participant
@danny-avila