🔒 fix: Memory Disabled Config UI Permissions #9522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I fixed a bug where setting
memory.disabled: true
inlibrechat.yaml
had no effect on the UI, allowing memory functionality to remain visible and accessible in the sidepanel despite being explicitly disabled.packages/api/src/app/permissions.ts
to properly detect when memory is explicitly disabled via configurationfalse
whenmemory.disabled: true
isMemoryEnabled
function in tests to use the actual implementation for more accurate testingChange Type
Testing
I tested the fix by implementing comprehensive unit tests that verify the memory permission system works correctly in both disabled and enabled states. The tests confirm that when
memory.disabled: true
is set in the configuration, all memory-related permissions are set tofalse
, which prevents the memory functionality from appearing in the UI sidepanel.Test Configuration:
memory.disabled: true
Checklist