🔧 fix: Apply Convo Export filename sanitization at export, not input #8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny-avila
approved these changes
Jul 31, 2025
danny-avila
changed the title
danny-avila
approved these changes
Jul 31, 2025
xycjscs
pushed a commit
to xycjscs/LibreChat
that referenced
this pull request
Aug 9, 2025
…anny-avila#8779) Co-authored-by: Woosub Kim <[email protected]>
miguelwon
pushed a commit
to miguelwon/LibreChat
that referenced
this pull request
Aug 10, 2025
…anny-avila#8779) Co-authored-by: Woosub Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Korean character composition issue in the export filename input. Previously,
filenamify()was called on every keystroke, which preventedThe fix moves filename sanitization from input time to export time, allowing proper character composition while still ensuring safe filenames.
Change Type
Testing
Test Configuration:
Before
Jul-31-2025.17-26-06.mp4
After
Jul-31-2025.17-26-21.mp4
Checklist