Skip to content

🐛 fix: Temporary Chats Still Visible in Sidebar #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2025
Merged

Conversation

dustinhealy
Copy link
Collaborator

@dustinhealy dustinhealy commented Jul 27, 2025

Summary

The Conversation and Message models were importing the entire exports object instead of destructuring the getCustomConfig function, causing "getCustomConfig is not a function" errors when creating temporary chats.

This error was silently caught and caused temporary chats to be saved as permanent chats (with expiredAt = null), creating a frontend/backend state mismatch where chats only appeared in the sidebar after page refresh.

Fixed by changing the imports to properly destructure the function from the exports object.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

Manual verification in UI of temporary chats now no longer appearing in sidebar on refresh

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings

@dustinhealy dustinhealy marked this pull request as ready for review July 27, 2025 01:32
@danny-avila danny-avila merged commit d6a65f5 into dev Jul 27, 2025
5 checks passed
@danny-avila danny-avila deleted the fix/temp-chats branch July 27, 2025 15:42
@danny-avila danny-avila mentioned this pull request Jul 28, 2025
10 tasks
jhrozek pushed a commit to StacklokLabs/LibreChat that referenced this pull request Jul 31, 2025
* 🐛 fix: Fix import error causing temporary chats to still display in sidebar

* refactor: Update import path for `getCustomConfig` in Conversation and Message models

* chore: eslint warnings

* ci: add tests for Conversation and Message models

---------

Co-authored-by: Danny Avila <[email protected]>
xycjscs pushed a commit to xycjscs/LibreChat that referenced this pull request Aug 9, 2025
* 🐛 fix: Fix import error causing temporary chats to still display in sidebar

* refactor: Update import path for `getCustomConfig` in Conversation and Message models

* chore: eslint warnings

* ci: add tests for Conversation and Message models

---------

Co-authored-by: Danny Avila <[email protected]>
miguelwon pushed a commit to miguelwon/LibreChat that referenced this pull request Aug 10, 2025
* 🐛 fix: Fix import error causing temporary chats to still display in sidebar

* refactor: Update import path for `getCustomConfig` in Conversation and Message models

* chore: eslint warnings

* ci: add tests for Conversation and Message models

---------

Co-authored-by: Danny Avila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants