🔄 fix: Update Agent Versioning to Include agent_ids
#7762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed agent_ids exclusion from version comparison in the Agent model. * Added tests to ensure agent_ids changes trigger new version creation and handle duplicates correctly. * Enhanced existing tests to validate agent_ids alongside other fields and preserve history.
danny-avila
changed the title
agent_ids
danny-avila
approved these changes
Jun 6, 2025
jmaddington
pushed a commit
to jmaddington/LibreChat
that referenced
this pull request
Jun 17, 2025
* Removed agent_ids exclusion from version comparison in the Agent model. * Added tests to ensure agent_ids changes trigger new version creation and handle duplicates correctly. * Enhanced existing tests to validate agent_ids alongside other fields and preserve history.
rhonyabdullah
pushed a commit
to rhonyabdullah/LibreChat
that referenced
this pull request
Jun 27, 2025
* Removed agent_ids exclusion from version comparison in the Agent model. * Added tests to ensure agent_ids changes trigger new version creation and handle duplicates correctly. * Enhanced existing tests to validate agent_ids alongside other fields and preserve history.
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Aug 4, 2025
* Removed agent_ids exclusion from version comparison in the Agent model. * Added tests to ensure agent_ids changes trigger new version creation and handle duplicates correctly. * Enhanced existing tests to validate agent_ids alongside other fields and preserve history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Agent model to properly track changes to the
agent_idsfield in the versioning system. Previously, changes toagent_idswere ignored when determining if a new version should be created, which could lead to lost history when agents were added or removed from the chain.It was falsely identifying a new agent chain as a duplicate version.
Change Type
Checklist
Copilot Summary
This pull request introduces changes to the
Agentmodel and its associated tests, focusing on the inclusion of theagent_idsfield in version detection and handling. The updates ensure that changes to theagent_idsfield are properly tracked, creating new versions when necessary, and include comprehensive test cases to validate this behavior.Changes to
Agentmodel:agent_idsfield from version comparison, allowing updates to this field to trigger new versions. (api/models/Agent.js)Updates to
Agenttests:Agentmodel within multiple test suites to ensure proper setup. (api/models/Agent.spec.js) [1] [2] [3] [4]agent_idscreate new versions.agent_idsremains unchanged.agent_idsupdates alongside other fields.agent_idsin version history.agent_idsarrays and agents without theagent_idsfield.