☀️ a11y: Add Missing Focus to Model Selector in Light Mode #7607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
danny-avila
changed the title
danny-avila
approved these changes
May 29, 2025
timmanik
pushed a commit
to timmanik/LibreChat
that referenced
this pull request
Jun 1, 2025
derhelge
pushed a commit
to derhelge/LibreChat
that referenced
this pull request
Jun 1, 2025
arthurolivierfortin
pushed a commit
to arthurolivierfortin/LibreChat-Fork
that referenced
this pull request
Jun 4, 2025
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the accessibility issue identified in #6638. With the introduction of the new ARIAKit LLM Menu, there was a regression in that the focus indicator was no longer showing up in light mode. This PR adds focus back to the main LLM menu in lightmode. The focus-visible classes of the component were interfering with the applications own focus-visible styles in styles.css
Issue as seen in the current version: missing focus
Suggested fix in the PR request: focus on LLM menu
Changed files:
NOTE: This partially replaces PR #6645 to immediately meet the WCAG SC 2.4.7 Focus Visible and allowing more time to work on the other issue in the PR #6645 which I made its own issue #7608, to improve the visibility of the submenu's active items.
Change Type
Testing
Manual keyboard testing: In light mode, use the tab key to ove keyboard focus to the LLM menu. The black focus outline around the menu button should be visible and match the focus style of other interactive elements (black, solid, 2px).
Test Configuration:
Checklist
Please delete any irrelevant options.