-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
🔒 fix: resolve session persistence post password reset #5077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te into user workflows
…ation logic in AuthService
…e, remove console.log()
Thanks, please check failing tests next time |
danny-avila
approved these changes
Dec 23, 2024
10 tasks
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Jan 21, 2025
) * ✨ feat: Implement session management with CRUD operations and integrate into user workflows * ✨ refactor: Update session model import paths and enhance session creation logic in AuthService * ✨ refactor: Validate session and user ID formats in session management functions * ✨ style: Enhance UI components with improved styling and accessibility features * chore: Update login form tests to use getByTestId instead of getByRole, remove console.log() * chore: Update login form tests to use getByTestId instead of getByRole --------- Co-authored-by: Danny Avila <[email protected]>
danny-avila
added a commit
that referenced
this pull request
Mar 27, 2025
* ✨ feat: Implement session management with CRUD operations and integrate into user workflows * ✨ refactor: Update session model import paths and enhance session creation logic in AuthService * ✨ refactor: Validate session and user ID formats in session management functions * ✨ style: Enhance UI components with improved styling and accessibility features * chore: Update login form tests to use getByTestId instead of getByRole, remove console.log() * chore: Update login form tests to use getByTestId instead of getByRole --------- Co-authored-by: Danny Avila <[email protected]>
MichielMAnalytics
pushed a commit
to MichielMAnalytics/ProAI
that referenced
this pull request
Jun 6, 2025
) * ✨ feat: Implement session management with CRUD operations and integrate into user workflows * ✨ refactor: Update session model import paths and enhance session creation logic in AuthService * ✨ refactor: Validate session and user ID formats in session management functions * ✨ style: Enhance UI components with improved styling and accessibility features * chore: Update login form tests to use getByTestId instead of getByRole, remove console.log() * chore: Update login form tests to use getByTestId instead of getByRole --------- Co-authored-by: Danny Avila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5072
Description:
Key Changes:
session.js
for the session schema and updated relevant models to import this schemacreateSession
,findSession
,updateExpiration
,deleteSession
,deleteAllUserSessions
,generateRefreshToken
, andcountActiveSessions
Files Modified:
📁 Models:
api/models/Session.js
: Refactor with new methods and error handlingapi/models/schema/session.js
: New session schema📊 Controllers:
api/server/controllers/AuthController.js
: Shifted to usingfindSession
anddeleteAllUserSessions
api/server/controllers/UserController.js
: UtilizesdeleteAllUserSessions
👩💻 Services:
api/server/services/AuthService.js
: Refactored for the new session methods🗂️ Miscellaneous:
api/models/index.js
: Updated export strategye2e/setup/cleanupUser.ts
: Test script updates for session cleanupChange Type
Testing
Test Configuration:
Checklist