Skip to content

🎨 style: remove break-all class in modelSpec menu #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

wipash
Copy link
Contributor

@wipash wipash commented Nov 24, 2024

Summary

Removes the break-all class added in #2731, as it doesn't seem to affect how long Chinese modelSpec descriptions are displayed, but causes long English descriptions to break on characters instead of on words.

Before:

image

After:
image

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Test config:

All npm run test:client tests pass.

The display of the menu is the same in both desktop and landscape, and across different UI languages.
Tested in Firefox, Edge, Chrome.

Tested with the following config:

modelSpecs:
  list:
    - name: claude-3-5-sonnet
      label: Claude
      description: Claude is an equally capable alternative to ChatGPT, with a different personality and approach to conversation
      preset:
        endpoint: anthropic
        model: claude-3-5-sonnet-20241022
        modelLabel: Claude
    - name: gpt-4o
      label: ChatGPT
      description: ChatGPT is great for general conversation and answering questions
      preset:
        endpoint: openAI
        model: chatgpt-4o-latest
        modelLabel: ChatGPT
    - name: o1-preview
      label: GPT-o1
      description: GPT-o1 is good at performing complex reasoning. It's slower and more verbose than ChatGPT.
      preset:
        endpoint: openAI
        model: o1-preview
        modelLabel: GPT-o1
    - name: "gemini"
      label: "Gemini"
      description: 该模型能够同时处理文本、图像、音频、视频和代码等多种数据类型,并具备生成高质量代码的能力。
      preset:
        endpoint: "google"
        model: "gemini-1.5-pro-latest"
        modelLabel: "Gemini"

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

Copy link

@jahanzaibtariq jahanzaibtariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Collaborator

@berry-13 berry-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@danny-avila danny-avila changed the title style: remove break-all class in modelSpec menu 🎨 style: remove break-all class in modelSpec menu Nov 25, 2024
@berry-13 berry-13 merged commit 07511b3 into danny-avila:main Nov 25, 2024
2 checks passed
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Nov 26, 2024
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
MichielMAnalytics pushed a commit to MichielMAnalytics/ProAI that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants