-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
⚡ feat: Gemini-1.5 Flash, gpt-4o
imports, modelSpec
greeting fix
#2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gpt-4o
imports, modelSpec
greeting fixgpt-4o
imports, modelSpec
greeting fix
@@ -202,7 +202,7 @@ function processConversation(conv, importBatchBuilder, requestUserId) { | |||
const isCreatedByUser = role === 'user'; | |||
let sender = isCreatedByUser ? 'user' : 'GPT-3.5'; | |||
const model = mapping.message.metadata.model_slug || openAISettings.model.default; | |||
if (model === 'gpt-4') { | |||
if (model.includes('gpt-4')) { | |||
sender = 'GPT-4'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Technically", it's GPT-4 and GPT-4o 😅 (ofc I haven't looked up what model
looks like)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works for when the model is vanilla "gpt-4" as well as "gpt-4o"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean about differentiating the sender, I'll think about that soon, as that would mean a few other changes app-wide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, tbh, I would'be just slapped all gpt-4-1106-preview
strings into a huge lookup table (and hide the actual model name e.g. under a hover on the username).
At least for the OpenAI models, that go like
gpt-4o-2024-05-13
gpt-4-1106-preview
gpt-3.5-turbo
I'd try e.g.
function extractUsername(modelName) {
// Check for specific model name patterns and return corresponding usernames
if (modelName.startsWith('gpt-4o-')) {
return 'GPT-4o';
} else if (modelName.startsWith('gpt-4-')) {
return 'GPT-4';
} else if (modelName.startsWith('gpt-3.5-turbo')) {
return 'GPT-3';
}
...
}
and/or something "smarter" (which ofc you can support with tests)
Ofc, up to you, the project, and your time 🙏 (and things I haven't seen, since I haven't really dug the source)
…2729) * fix: Gemini Flash stream fix * fix: correct `sender` field for gpt-4o imports from ChatGPT * add flash model examples and fix vertex streaming * style: modelSpec greeting fix
…anny-avila#2729) * fix: Gemini Flash stream fix * fix: correct `sender` field for gpt-4o imports from ChatGPT * add flash model examples and fix vertex streaming * style: modelSpec greeting fix
…anny-avila#2729) * fix: Gemini Flash stream fix * fix: correct `sender` field for gpt-4o imports from ChatGPT * add flash model examples and fix vertex streaming * style: modelSpec greeting fix
Summary
Closes #2714
Closes #2715
Closes #2718
Change Type
Checklist