Skip to content

Msg Clipboard to checkmark (optimistic UX) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2023

Conversation

techwithanirudh
Copy link
Contributor

@techwithanirudh techwithanirudh commented May 12, 2023

Added Msg Clipboard to checkmark (optimistic UX) support

@danny-avila
Copy link
Owner

Thank you for this, I will test it out as soon as I get the chance. There shouldn't be any merge conflicts as far as I can tell.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new Checkmark SVG, just use the one already in the project: client\src\components\svg\CheckMark.jsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info!

@danny-avila danny-avila merged commit bf31b1f into danny-avila:main May 14, 2023
@techwithanirudh techwithanirudh deleted the clipboard branch May 15, 2023 14:11
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
* revert unintended package-lock.json change

* used default checkmark which is included in project

---------

Co-authored-by: Danny Avila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants