Skip to content

fix: conversation title truncation #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

jonas-w
Copy link
Contributor

@jonas-w jonas-w commented Nov 27, 2023

Summary

  • Make title truncation work with ellipsis
    • The class for ellipsis was already there, but it didn't work because of overflow-hidden, but line-clamp-1 fixes this
  • Add tooltip, to see the full title

This would fix my own issue (#1236), but feel free to just reject this PR, if you want to keep it the same way it works on chat.openai.com (as it currently is).

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Testing

Tested in Chrome and Firefox.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila linked an issue Nov 28, 2023 that may be closed by this pull request
1 task
@danny-avila
Copy link
Owner

thank you!

@danny-avila danny-avila merged commit 822914d into danny-avila:main Nov 28, 2023
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Conversation Title truncation is abrupt
2 participants