Skip to content

fix(formatMessages): Conform Name Property to OpenAI Expected Regex #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix(formatMessages): Conform Name Property to OpenAI Expected Regex #1076

merged 2 commits into from
Oct 19, 2023

Conversation

danny-avila
Copy link
Owner

Summary

Fixes #1075

Thank you @walbercardoso @fuegovic for spotting this

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Added 2 unit tests to existing formatMessages.spec

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila linked an issue Oct 19, 2023 that may be closed by this pull request
[Bug]: GPT presets with a space in the name now cause an error #1075
Closed
1 task
@danny-avila danny-avila merged commit abbc57a into main Oct 19, 2023
@danny-avila danny-avila deleted the preset-name-fix branch October 19, 2023 14:02
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
@danny-avila
fix(formatMessages): Conform Name Property to OpenAI Expected Regex (d…
e8c0039 
…anny-avila#1076)

* fix(formatMessages): conform name property to OpenAI expected regex

* fix(ci): prior test was expecting non-sanitized name input
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
@danny-avila
fix(formatMessages): Conform Name Property to OpenAI Expected Regex (d…
a669ce7 
…anny-avila#1076)

* fix(formatMessages): conform name property to OpenAI expected regex

* fix(ci): prior test was expecting non-sanitized name input
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
@danny-avila
fix(formatMessages): Conform Name Property to OpenAI Expected Regex (d…
918fb6d 
…anny-avila#1076)

* fix(formatMessages): conform name property to OpenAI expected regex

* fix(ci): prior test was expecting non-sanitized name input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: GPT presets with a space in the name now cause an error
1 participant
@danny-avila