Skip to content

Conversation

th1000s
Copy link
Collaborator

@th1000s th1000s commented Nov 18, 2021

The fake value is valid for exactly one call, the state for this is stored per-thread.

The fake value is valid for exactly one call, the state for
this is stored per-thread.
@dandavison dandavison mentioned this pull request Nov 19, 2021
@dandavison dandavison marked this pull request as ready for review November 21, 2021 21:08
@dandavison
Copy link
Owner

See #774 (comment) I'm wondering whether there's an interaction between threads. (But equally possible I'm doing something stupid due to limited understanding of the clever stuff going on here!)

@dandavison dandavison merged commit 0a0a3e0 into dandavison:master Nov 22, 2021
@dandavison
Copy link
Owner

Thanks very much for this! I hope you don't mind me erring on the side of merging fairly aggressively (once the branch seems basically correct) and applying any improvements / beautification subsequently in master. My experience has been that the fewer unmerged feature branches the better in order to maintain velocity with multiple collaborators. What will suffer somewhat is the beauty of our git history.

@th1000s
Copy link
Collaborator Author

th1000s commented Nov 27, 2021

No problem. Of course ideally this PR and the one depending on it would inform each others design, but that would indeed be too slow. Beautification PR now up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants