Use fatal() to exit with errorcode 2 #739
Conversation
| time, | ||
| line_number, | ||
| code, | ||
| }) |
There was a problem hiding this comment.
Ah, thanks! I had not internalised that ? could be used on Option. I had thought of it only in the context of Result (error-handling in general is an area in which the delta codebase could be improved -- I haven't dealt properly with situations that involve different Result types.)
There was a problem hiding this comment.
LGTM!
Is there any reason not to use this in the subcommands/diff module and eliminate the config.error_exit_code variable? I'll open a PR for that unless it turns out that I can see why you didn't do it.
EDIT: OK, I see subcommands/diff doesn't actually exit, it just computes appropriate integer exit codes, so it's less obvious how/whether to refactor.
|
Thanks a lot for this clean up. It is of course an important part of the public API as well as being a codebase improvement. |
Use question mark operator instead
dandavison
force-pushed
the
more_fatal
branch
from
436183a to
e0e62a6
Compare
|
Rebased on master to resolve conflict |
2 participants
Now process::exit is only called in four places.
Plus some small improvements.