Width can be an offset from the terminal width #727
Conversation
|
Done and done! I hope the code to produce precise error messages for wrong arguments isn't too much :) |
|
This PR would undo the implicit fixes for |
src/cli.rs
Outdated
| /// full terminal width. | ||
| /// The width of underline/overline decorations. Can be absolute, absolute [+|-] offset, or | ||
| /// only an offset - in the last case the detected terminal width is changed | ||
| /// by the offset. Examples: "72", "80-2", "-2" or "98+2". |
There was a problem hiding this comment.
Can you remind me what a common use case for + is?
There was a problem hiding this comment.
Honestly, none that I can think of - feature completeness? Making sure the ALU still knows how to add?
There was a problem hiding this comment.
Haha :) okay, I'm just thinking about how to make it as easy as possible to understand. What do you think about something like
The width of underline/overline decorations. Examples: "72" (exactly 72 characters), "-2" (auto-detected terminal width minus 2). An expression such as "74-2" is also valid (equivalent to 72 but may be useful in shell programming if a variable exists holding the value "74").
|
@th1000s this is marked "Draft" -- is that accurate, or is it ready to merge? |
|
This commit is part of the work to restore ANSI sequences in side-by-side mode. I pushed it early because it changes the UI a bit and wanted to give it some time for feedback. Lets wait for the other PR before merging this :) |
No longer subtract 1 from the terminal width to accommodate e.g. `less --status-columns`, instead set `--width -1` explicitly.
2 participants
No longer subtract 1 from the terminal width to accommodate e.g.
less --status-columns, instead set--width -1explicitly.Using line wrapping combined with ANSI codes to extend the terminal width requires exact knowledge of the painted area, so make reductions of it more explicit.
--width 123-4is also possible in to make calling with e.g.$myCOLS-2possible.