Skip to content

Conversation

marcoieni
Copy link
Contributor

Fix #463
Ugly, but it works. I am sure there is a better solution, so if you can find it, great!

@dandavison
Copy link
Owner

@marcoieni can you explain why this fixes the problem?

@marcoieni
Copy link
Contributor Author

Not really! 😅
I just noticed that if output_type.handle().unwrap(), i.e. writer is passed as function argument it doesn't work. I think it has to do with lifetimes, but the rust compiler doesn't complain.
I think that a better fix would be to edit the handle function.

@dandavison
Copy link
Owner

I think I (eventually!) found a cleaner solution: #469

@dandavison dandavison closed this Dec 27, 2020
@dandavison
Copy link
Owner

Thanks very much @marcoieni for locating the bug and pointing out that the fix was to stop that writer getting destroyed too early.

@marcoieni marcoieni deleted the fix-463 branch December 27, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 delta 0.4.5 binary release messes up terminal on Ubuntu 20 04

3 participants