Support for maxLineLength setting in vscode-settings

[Nxt3]

I've seen it recommended a few places here to use the maxLineLength: 0 setting when running into issues with prettier.

Would it be possible to set this in vscode settings as opposed to the importSorter config?

[daidodo]

@Nxt3, thanks for the feedback!

Could you provide links about the issues and recommendations? I need to understand them better before making decisions.

Basically, maxLineLength is not in VS Code settings because it's covered by Prettier and EditorConfig. VS Code settings are generally not recommended IMHO because it's not portable in team works. But I'm open to different perspectives.

[Nxt3]

Sure: #36 (comment) and #29 (comment)

[daidodo]

Ah, I see where you're from.

Are you having the same issue with #36? If yes, maxLineLength won't help you as commented. The real solve for that would be either disabling formatting or compatible with Prettier.

[Nxt3]

Yes I'm running into the same problem. If there was a way to have it format so that everything is always on one line and then let prettier handle it that would probably be the fix.

[daidodo]

That's essentially running prettier after this extension, which you said couldn't achieve.

[Nxt3]

The other person was posting the issue was saying that if you had the following:

import { FakeImportWithVeryLooongName } from './components/fake-import-file-name-very-loooong/fake-import-file-name-very-loooong';

ts-import-sorter would format it like so:

import {
  FakeImportWithVeryLooongName
} from './components/fake-import-file-name-very-loooong/fake-import-file-name-very-loooong';

whereas prettier would leave it like this:

import { FakeImportWithVeryLooongName } from './components/fake-import-file-name-very-loooong/fake-import-file-name-very-loooong';

so that would imply that there is some extra processing happening in ts-import-sorter to make that happen, right?

[daidodo]

Yes, this extension pre-calculates the line length and if it exceeds the limit, it will wrap the statement.
To be honest, I don't think prettier is following the limit fully but a compatible fall-back can be implemented.

[Nxt3]

That's correct: prettier does not format imports in that way; it's left as one-line regardless of line length.

https://prettier.io/docs/en/rationale.html#imports

[daidodo]

Thanks for the reference, that's helpful!

So what I recommend now is implementing the compatible behaviour with prettier, if it's found. Otherwise wrap the line.
What do you think?

And this shouldn't be a big change so it's more than welcome if you'd like to do it in case you're interested.

[Nxt3]

Any chance you could point me to which files to look at? If I found some time I wouldn't mind taking a stab.

[daidodo]

Thanks!
Perhaps the first step is to take a look at CONTRIBUTING.md.
The prettier config is read here so you know if it's found.
And the start point of composing an import is here.

One note is that you might want to check whether the following are wrapped or not by prettier:

import 'a-veeeeeeery-looooooooooong-veeeeeeery-looooooooooong-script';
import A = require('b-veeeeeeery-looooooooooong-veeeeeeery-looooooooooong-module');

As this extension WILL wrap them.

[karlhorky]

This is great, compatibility with Prettier would be awesome! Look forward to this change!

[daidodo]

@Nxt3, have you started anything on this thread? Otherwise I'm going to pick it up soon. Thanks!