Launchpad - browser pre-selection rules

[sync-by-unito]

Summary

In 9.x we have logic and tests to preselect the first custom browser if one is found, instead of preselecting the default browser.

To have parity with 9.x, we should match this behavior.

There are some tests/logic around localStorage, which is not in use in 10.0, so that logic should check if a browser has already been definitively chosen by the user, in which case that previously opened browser should be remembered. We may need to add something to track the touched/untouched state of a browser choice and make it available in graphql.

Acceptance Criteria

• The logic and tests from 9.x for this behavior should be represented in 10.0-release.
• Electron is the default preselected browser when a custom browser is not present
• When a custom browser is present, it is preselected
• If any browser has been opened, that browser is preselected next time (even if it was Electron… hence we need to know touched/untouched state and can’t always prioritize the custom browser over Electron)

Resources

Test in develop branch: browsers dropdown > preselects the custom browser in packages/desktop-gui/cypress/integration/project_nav_spec.js

9.x implementation:

cypress/packages/desktop-gui/src/project/project-model.js

Lines 180 to 185 in 24774b6

	const customBrowser = _.find(this.supportedBrowsers, { custom: true })
	if (customBrowser) {
	return this.setChosenBrowser(customBrowser, { save: false })
	}

A slack thread confirming that the order of browsers should be alphabetical and that the current default browser choice preselected will be be Electron, but that we will preselect the last one used. This doesn’t seem to be implemented.

Open Pull Requests

Any PRs needed for review

┆Issue is synchronized with this Jira Task by Unito
┆author: Mark Noonan
┆epic: 9.x Parity
┆friendlyId: UNIFY-1423
┆priority: Low
┆sprint: Backlog
┆taskType: Task

[sync-by-unito]

➤ Zach Bloomquist commented:

Hey Mark Noonan , this has some (total?) overlap with #20760, can these be combined somehow?

[sync-by-unito]

➤ Mark Noonan commented:

Zach Bloomquist oh cool, yes. I think it’s not total overlap unless that PR also prioritizes the custom browser over electron as the preselected choice, if there is no stored choice.

Context for this ticket was auditing the 9.x tests, I didn’t check in-flight issues though.

[sync-by-unito]

➤ Zach Bloomquist commented:

Actually I think I’m supposed to wait for this to be prioritized… 😃

[github-actions]

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

[cypress-app-bot]

This issue has been closed due to inactivity.