-
Notifications
You must be signed in to change notification settings - Fork 22
Update BrandMomentCaptureIntro animation toggle #5853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update BrandMomentCaptureIntro animation toggle #5853
Conversation
🦋 Changeset detectedLatest commit: 5190a7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I've create a branch we're I've partially implemented the idea Lua had made a here since its less aggressive than what we had before - Branch here. The Button is using the secondary variant and I've also added an onClick to the VideoPlayer to toggle the animation. ^ These screenshots are no longer relevant |
06fab73 to
99a8d5f
Compare
f8934e3 to
6513287
Compare
| .landscape { | ||
| aspect-ratio: 4/3; | ||
|
|
||
| @supports not (aspect-ratio: auto) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can safely use this without a fallback as it's a baseline widely avaiable feature and it landed 4+ years ago in most browsers
|
Going to put this back into draft until the design direction has been decided |


Why
In the current implementation of
BrandMomentCaptureIntrothe toggle to stop the loop animation is hidden behind a hover or focus event.This presents an issue for individuals that have motion sensitivity as they may not know they can pause the animation. This was flagged as a medium severity issue in the recent Intopia Audit of the Capture Survey experience.
While this is technically the case with all of our animate-able
Scenecomponents, this PR only addresses theBrandMomentCaptureIntrocomponent to limit the scope of impact. This is to allow for a potential design solution or rethink of the animation toggle styles and position that has design curators approval, before it is rolled out across the product.What
hasVisibleAnimationToggleprop toVideoPlayerBrandMomentCaptureIntromultiple animated videos to render with the toggle visibleButtoncomponentSceneillustrationsSceneillustrations and warn about potential usageBrandMomentCaptureIntroin a similar scenario to how it is used in prodBefore
Toggle animation button only shows when hovering on image or on focus.
Hovering the button has a unique hover state not aligned to our buttons.