chore: mainnet deployment #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock-script into mainnet-deployment
|
If you prefer not to make your email address public, please provide one of the following alternatives instead:
Anyone can use the information you provide to verify that you own the CKB address. |
tea2x
reviewed
Oct 8, 2025
| ## step 1: verify binary | ||
| function verify_binary() { | ||
| get_expected_hash() { | ||
| grep "build/release/c-sphincs-all-in-one-lock$" ../../checksums.txt | awk '{print $1}' |
There was a problem hiding this comment.
I got a question.
Shouldn't checksum be calculated on the binary instead of being grepped from checksum.txt?
Or maybe there should be a checksum validation prior to this function?
There was a problem hiding this comment.
The checksums.txt is from reproducible build. See
quantum-resistant-lock-script/scripts/reproducible_build_docker
Lines 62 to 66 in da0a761
So we don't need to build it from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the deployment configuration by reading this guide first.
After completing your review, please approve this deployment or leave a comment with "LGTM" if you don't have approval permissions. Once we receive approval from all 5 reviewers, the deployment will be signed and broadcast to the P2P network.