Leverage another LLVM binary to locate current clang binary #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different distros package LLVM / clang into different setups: * Fedora 41's clang package provides clang, clang-19 and llvm-ar * Ubuntu 24.04's clang package provides clang, clang-18 and llvm-ar-18 Previously, we rely on clang's binary name to infer names for other binaries. But given the above packaging reality, relying on binary clang introduces ambiguity. This commit changes the code so we now rely on another binary, such as llvm-strip or llvm-strip-18 to detect the suffix, and then piece together the binary names we will invoke.
xxuejie
force-pushed
the
find-clang-via-another-bin
branch
from
5abfe31 to
3248934
Compare
XuJiandong
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different distros package LLVM / clang into different setups:
Previously, we rely on clang's binary name to infer names for other binaries. But given the above packaging reality, relying on binary clang introduces ambiguity.
This commit changes the code so we now rely on another binary, such as llvm-strip or llvm-strip-18 to detect the suffix, and then piece together the binary names we will invoke.