Skip to content

Conversation

xxuejie
Copy link
Collaborator

@xxuejie xxuejie commented Sep 20, 2024

While there is experimental support for A extension in CKB-VM, no CKB versions enable A extension for now. This commit fixes makefile so we are not generating any instruction from A extension by default, which would be a benefit for developers(since they don't have to do this by themselves)

While there is experimental support for A extension in CKB-VM, no CKB
versions enable A extension for now. This commit fixes makefile so we
are not generating any instruction from A extension by default, which
would be a benefit for developers(since they don't have to do this by
themselves)
@xxuejie xxuejie assigned XuJiandong and unassigned XuJiandong Sep 20, 2024
@xxuejie xxuejie requested a review from XuJiandong September 20, 2024 05:53
@XuJiandong
Copy link
Contributor

We will release ckb-std 0.16.0 with dummy-atomic as default feature in the following week.
After releasing, the dependency of ckb-std can be updated to 0.16.0.

@xxuejie
Copy link
Collaborator Author

xxuejie commented Sep 20, 2024

To be honest I don't think the problem is ckb-std, it is actually molecule (which is typically used by ckb-gen-types). Even when someone uses an older version of ckb-std but upgrades ckb-gen-types or molecule, this could still be an issue.

I've updated the documentation with this change.

@xxuejie xxuejie force-pushed the disable-a-extension-by-default branch from 8231d07 to 0260b03 Compare September 20, 2024 06:06
@xxuejie xxuejie merged commit c4a147d into main Sep 23, 2024
8 checks passed
@xxuejie xxuejie deleted the disable-a-extension-by-default branch September 23, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants