fix(labels): edit labels for distinct recordings with identical file names #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewazores
left a comment
andrewazores
left a comment
There was a problem hiding this comment.
Looks good, but I'll wait for cryostatio/cryostat#971 before giving final approval/merging.
maxcao13
force-pushed
the
graphql-labels
branch
from
6aebe92 to
53bf04c
Compare
Member
|
Just updated some failing graphql requests which weren't updated when cryostatio/cryostat#924 was merged. The ActiveRecording graphql queries will also need to be cleaned up when cryostatio/cryostat#1030 is implemented. |
andrewazores
force-pushed
the
graphql-labels
branch
from
6e038bf to
bf698b1
Compare
andrewazores
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
Uses the backend fix from cryostatio/cryostat#971 to modify and retrieve archived recording labels saved from a specified target.
I'll add another follow-up PR to apply the same fix to the all-archives view once Hareet merges his.