fireEvent.sigkill fails on some CI systems

[crutchcorn]

While this code runs on all the same versions of Node on Windows within CI, it seems to error out on platforms like Windows.

Log:

https://github.com/crutchcorn/cli-testing-library/runs/4339953929?check_suite_focus=true

It appears to be a permissions issue of being unable to taskkill (or similar) a PID on Windows machines on GH Actions CI. This makes sense to me, as it may introduce vulnerabilities.

As a temporary workaround, I will be removing that test from CI and simply doing tests manually on Windows myself. Please let us know if there's a better way you know of

[crutchcorn]

OK I'm stumped. I've tried for hours and hours now with no avail. It seems to work fine in CircleCI, but not GitHub actions.

I'm going to mark this as "help needed" and hope the ecosystem has some kind of solution

Note: This library works fine for Windows itself. I will be manually testing everything on my machine to make sure it works and continue to write Windows-specific tests

[crutchcorn]

OK it's not just sigkill and it's not just Windows

https://github.com/crutchcorn/cli-testing-library/actions/runs/1558975085

There is some timing issue somewhere, and I don't think it's our code, but I could be wrong.

[crutchcorn]

I fixed the timing issue (Node 14 seems to have changed something with spawn behavior that Node 12 doesn't have)

Sure enough, both Windows and Ubuntu tests pass now

https://github.com/crutchcorn/cli-testing-library/runs/4522732155?check_suite_focus=true

https://github.com/crutchcorn/cli-testing-library/runs/4522795843?check_suite_focus=true

[crutchcorn]

We're running into this issue again in Plop as Windows devices are failing again.

I'm willing to pay a bounty of $50 if anyone is able to solve these issues well enough that Windows CI systems do not fail on GitHub actions on the Plop monorepo 5x in a row.

[crutchcorn]

/bounty $50

[algora-pbc]

💎 $50 bounty created by crutchcorn
🙋 If you start working on this, comment /attempt #3 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #3 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to crutchcorn/cli-testing-library!

Attempt	Started (GMT+0)	Solution
🟢 @smartbizlord	Dec 31, 2023, 5:42:05 AM	WIP
🟢 @Waldeedle	Jan 1, 2024, 8:13:43 PM	#26

[smartbizlord]

/attempt #3

Options

• Cancel my attempt

[Drex72]

OK I'm stumped. I've tried for hours and hours now with no avail. It seems to work fine in CircleCI, but not GitHub actions.

I'm going to mark this as "help needed" and hope the ecosystem has some kind of solution

Note: This library works fine for Windows itself. I will be manually testing everything on my machine to make sure it works and continue to write Windows-specific tests

Hey @crutchcorn Is it possible for me to get the config that you used for circle ci?