Feature/rds tags ignore #2252
Closed
Feature/rds tags ignore #2252
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridik-il
changed the title
ridik-il
force-pushed
the
feature/rds-tags-ignore-and-read-replicas
branch
5 times, most recently
from
e68c04e to
3fcfd88
Compare
- Adds TagIgnorePrefixes to DBInstance spec - Filters out tags with ignored prefixes from diff logic - Adds unit test coverage - Builds on top of read replica support Signed-off-by: Riyad Ilyasov <[email protected]>
ridik-il
force-pushed
the
feature/rds-tags-ignore-and-read-replicas
branch
from
3fcfd88 to
16c26ab
Compare
|
opened another one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR extends the tag reconciliation logic for RDS DBInstances.
Previously, the reconciler always ignored tags with the aws: prefix. Now, users can configure additional prefixes to ignore via the new tagIgnorePrefixes field in CustomDBInstanceParameters.
This helps prevent unnecessary updates caused by system-generated or external tags (e.g., aws:, c7n:).
Changes:
Added TagIgnorePrefixes field to CustomDBInstanceParameters and CRD schema.
Updated reconciliation logic to append user-provided prefixes to the default aws: prefix.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests added and run via make reviewable test.
Verified CRD generation and behavior of tag diff logic against mocked AWS responses.
Manually tested in test envs