epoch: Remove ptr-to-int casts #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
changed the title
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
from
533296d to
a1a79cd
Compare
taiki-e
changed the title
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
3 times, most recently
from
74a77dc to
cc5649a
Compare
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
from
cc5649a to
ca8880b
Compare
taiki-e
commented
May 16, 2022
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
from
ca8880b to
b229192
Compare
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
3 times, most recently
from
bca864d to
4e0f1d1
Compare
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
3 times, most recently
from
fda7170 to
59ec328
Compare
Merged
bors bot
added a commit
that referenced
this pull request
Jul 19, 2022
870: Fix miri test failure r=taiki-e a=taiki-e Split the non-breaking part from #796. Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jul 19, 2022
870: Fix miri test failure r=taiki-e a=taiki-e Split the non-breaking part from #796. Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
5 times, most recently
from
aa8d95c to
7ef27ed
Compare
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
5 times, most recently
from
378cf5a to
99a3451
Compare
|
Is there a specific question? I won't be able to do a review of the entire patch. |
|
Sorry, I noticed I have no questions on this PR... |
taiki-e
force-pushed
the
epoch-remove-ptr-to-int-casts
branch
from
99a3451 to
46d0777
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 23, 2022
796: epoch: Remove ptr-to-int casts r=taiki-e a=taiki-e Use [this hack](rust-lang/miri#1866 (comment)) to fix compatibility issues with Miri (see #490 (comment) for details). Due to the #545, still not compatible with stacked borrows. This will be fixed by the subsequent PR (#871). Note: this is a breaking change because changes API of Pointable and Pointer traits Fixes #579 881: Remove deprecated items r=taiki-e a=taiki-e This removes the following deprecated items: - crossbeam-epoch: - `CompareAndSetError` - `CompareAndSetOrdering` - `Atomic::compare_and_set` - `Atomic::compare_and_set_weak` - crossbeam-utils: - `AtomicCell::compare_and_swap` Co-authored-by: Taiki Endo <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
bors bot
added a commit
to taiki-e/portable-atomic
that referenced
this pull request
Jul 31, 2022
23: Provide stable equivalent of #![feature(strict_provenance_atomic_ptr)] r=taiki-e a=taiki-e This provides stable equivalent of [`#![feature(strict_provenance_atomic_ptr)]`](rust-lang/rust#99108). - `AtomicPtr::fetch_ptr_{add,sub}` - `AtomicPtr::fetch_byte_{add,sub}` - `AtomicPtr::fetch_{or,and,xor}` These APIs are compatible with strict-provenance on `cfg(miri)`. Otherwise, they are compatible with permissive-provenance. Once `#![feature(strict_provenance_atomic_ptr)]` is stabilized, these APIs will be strict-provenance compatible in all cases from the version in which it is stabilized. (This is also a generalization of what [I did in crossbeam-epoch](crossbeam-rs/crossbeam#796).) Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this hack to fix compatibility issues with Miri (see #490 (comment) for details).
Due to the #545, still not compatible with stacked borrows. This will be fixed by the subsequent PR (#871).
Note: this is a breaking change because changes API of Pointable and Pointer traits
Fixes #579