Fix tests on Windows #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un_in_background` PowerShell uses a built-in for `echo`, which doesn't play well with the test. I replaced it with a call to `cargo` because that should be available in the path of any machine that runs `cargo test`.
|
This is awesome, thanks a million for the contribution. |
crisidev
reviewed
Apr 24, 2025
|
Don't worry about the code-coverage check failing, it's because it's using a token scoped to my user. I should fix it sooner or later. |
Signed-off-by: Matteo Bigoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes failing tests on Windows, possibly resolving #10. It is not intended to represent a comprehensive review of the code or functionality on Windows, but it does fix the bug that was causing certain tests to fail. The problem was fixed by using
folder.uri.to_file_path().unwrap()instead ofPathBuf::from(folder.uri.path())in thediagnosticsmethod. The.to_file_path()method handles Windows paths correctly, but the.unwrap()introduces the possibility of a panic ifdiagnosticsis ever called with a non-fileURL. It should probably use a sensible default instead, or at least pass the error in its return value.A few other changes in this pull request include the removal of an unused import, swapping
cargo --versioninto the background test so that test doesn't fail in PowerShell environments, and enabling a test that was previously disabled on Windows.