Skip to content

Conversation

@crccheck
Copy link
Owner

@crccheck crccheck commented Dec 10, 2021

I've been using Poetry because it takes the hassle out of virtualenv management and has sane defaults that just work for building artifacts and uploading to PyPI.

Because I had to redo how tests were run, I went ahead and removed the Tox testing requirement too and so I had to redo the Github Actions for testing too.

One thing I didn't anticipate is that Github Actions caching doesn't work for Poetry, only with requirements.txt and Pipenv https://github.blog/changelog/2021-11-23-github-actions-setup-python-now-supports-dependency-caching/

Verifying the change

I compared python setup.py build vs poetry build and the only difference was some top level meta differences and Poetry added the tests directory which is fine. Both have the .html templates which is the important thing.

@crccheck crccheck force-pushed the switch-to-poetry branch 3 times, most recently from 88f21f8 to 82f864d Compare December 10, 2021 05:50
@crccheck crccheck force-pushed the switch-to-poetry branch 2 times, most recently from 33fda2e to fbe4358 Compare December 10, 2021 06:35
@crccheck crccheck changed the title chore: switch to poetry refactor: switch to Poetry for env+dep management Dec 10, 2021
@crccheck crccheck marked this pull request as ready for review December 11, 2021 07:50
@crccheck crccheck merged commit f16cb00 into master Dec 12, 2021
@crccheck crccheck deleted the switch-to-poetry branch December 12, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants