Skip to content

Conversation

@ccoVeille ccoVeille force-pushed the go-exclusions branch 2 times, most recently from 03c728f to 93c5957 Compare October 6, 2025 21:35
@ccoVeille
Copy link
Contributor Author

sorry for the missing comma in 93c5957

It's fixed now

@epage
Copy link
Collaborator

epage commented Oct 6, 2025

Something I've considered is running typos on at least common language's standard library APIs (and in fact did that for Python in #261). and generating common lists like this.

Looks like cspell does that, see https://github.com/streetsidesoftware/cspell-dicts/tree/main/dictionaries

@coveralls
Copy link

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 18295337437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 19.183%

Totals Coverage Status
Change from base Build 18295133403: 0.0%
Covered Lines: 535
Relevant Lines: 2789

💛 - Coveralls

@ccoVeille
Copy link
Contributor Author

now fixing with rustfmt

Pardon the random Gopher here 😁

@ccoVeille
Copy link
Contributor Author

Something I've considered is running typos on at least common language's standard library APIs (and in fact did that for Python in #261). and generating common lists like this.

Looks like cspell does that, see streetsidesoftware/cspell-dicts@main/dictionaries

Yes, I'm also involved in cspell-dicts repository, I'm aware of it.

I launched some tests against the generated version of cspell-dicts to double-check.

@ccoVeille
Copy link
Contributor Author

There are also a bunch of R_ARM_THM constants that are reported by typos, but they are rarely used

List of constants R_ARM_THM_ABS5 R_ARM_THM_ALU_ABS_G0_NC R_ARM_THM_ALU_ABS_G1_NC R_ARM_THM_ALU_ABS_G2_NC R_ARM_THM_ALU_ABS_G3 R_ARM_THM_ALU_PREL_11_0 R_ARM_THM_GOT_BREL12 R_ARM_THM_JUMP11 R_ARM_THM_JUMP19 R_ARM_THM_JUMP24 R_ARM_THM_JUMP6 R_ARM_THM_JUMP8 R_ARM_THM_MOVT_ABS R_ARM_THM_MOVT_BREL R_ARM_THM_MOVT_PREL R_ARM_THM_MOVW_ABS_NC R_ARM_THM_MOVW_BREL R_ARM_THM_MOVW_BREL_NC R_ARM_THM_MOVW_PREL_NC R_ARM_THM_PC12 R_ARM_THM_PC22 R_ARM_THM_PC8 R_ARM_THM_RPC22 R_ARM_THM_SWI8 R_ARM_THM_TLS_CALL R_ARM_THM_TLS_DESCSEQ16 R_ARM_THM_TLS_DESCSEQ32 R_ARM_THM_XPC22

@epage
Copy link
Collaborator

epage commented Oct 7, 2025

Thanks!

@epage epage merged commit 62a3b50 into crate-ci:master Oct 7, 2025
21 checks passed
@ccoVeille ccoVeille deleted the go-exclusions branch October 7, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants