GH action not working for windows because of wget

[Its-Just-Nans]

This actions assumes that wget is already installed which is not true for windows-latest

This produces the error

D:\a\_actions\crate-ci\typos\v1.28.4/action/entrypoint.sh: line 43: wget: command not found

The action requires

    - name: Install wget for Windows
      if: matrix.os == 'windows-latest'
      run: choco install wget --no-progress

Little bit related to #1095

[epage]

In #769, we've been also having issues with wget being needed.

#772 proposed making features optional that were unsupported by busybox. #1125 proposed providing a fallback to another common tool.

Our options for this

• Require the caller to install it (current for Windows, Alpine)
• Have entrypoint.sh install it (as proposed in use choco to download wget #1192)
  • Or put this in action.yml
• Fallback to windows-support approach (similar to the proposal in action: Support curl or wget, not just wget #1125)

The question for me is what approach we should take and why. At the outset, I'm not too thrilled about entrypoint.sh installing unrelated tools.

[Its-Just-Nans]

Thanks for the informations

I'm making a PR to at least have more documentation

Also, why not using an "input action" like download_if_needed and combine

• https://github.com/crate-ci/typos/pull/1125/files
• https://github.com/crate-ci/typos/pull/1192/files

to use curl or wget or use choco (to install it - on windows)

[Its-Just-Nans]

Also, why not using cargo install typos@VERSION in entrypoint.sh

Cargo is installed on all runner no ?

[epage]

to use curl or wget or use choco (to install it - on windows)

That is a point of discussion in #772

Also, why not using cargo install typos@VERSION in entrypoint.sh

The intention behind pre-built binaries is to avoid the build-time costs.

[Its-Just-Nans]

Okay, so I propose

Add an "input action" like download_if_needed
I think most people want the typos actions work out of the box, so by default it's download_if_needed: true

Add an "input action" like wget_args
by default wget_args: "--progress=dot:mega" -> busybox user can just disable the wget poblem (fix #772)

if this download_if_needed is true

• use https://github.com/crate-ci/typos/pull/1125/files to download the file with curl if present
• on windows, use choco to download wget https://github.com/crate-ci/typos/pull/1192/files

[rparrett]

The intention behind pre-built binaries is to avoid the build-time costs.

Is cargo-binstall an option?