packaging version conflicts between dry run and execute

[wade-cheng]

The dry run said "Packaging v1.0.0," but the execution said "Packaging v1.0.1." I've looked at the reference, and this doesn't seem to be mentioned, so I'm pretty sure this is a bug?

$ cargo release patch 
   Upgrading sfn-tpn from 1.0.0 to 1.0.1
  Publishing sfn-tpn
    Updating crates.io index
   Packaging sfn-tpn v1.0.0 (C:\Users\2014w\Desktop\important and misc\sfn-tpn)
    Updating crates.io index
    Packaged 11 files, 119.7KiB (32.6KiB compressed)
   Uploading sfn-tpn v1.0.0 (C:\Users\2014w\Desktop\important and misc\sfn-tpn)
warning: aborting upload due to dry run
     Pushing Pushing main, v1.0.1 to origin
warning: aborting release due to dry run; re-run with `--execute`

$ cargo release patch --execute
Release sfn-tpn 1.0.1? [y/N] 
y
   Upgrading sfn-tpn from 1.0.0 to 1.0.1
warning: in the working copy of 'Cargo.lock', LF will be replaced by CRLF the next time Git touches it
warning: in the working copy of 'Cargo.toml', LF will be replaced by CRLF the next time Git touches it
[main 0488a25] chore: Release sfn-tpn version 1.0.1
 2 files changed, 2 insertions(+), 2 deletions(-)
  Publishing sfn-tpn
    Updating crates.io index
   Packaging sfn-tpn v1.0.1 (C:\Users\2014w\Desktop\important and misc\sfn-tpn)
    Updating crates.io index
    Packaged 11 files, 119.7KiB (32.6KiB compressed)
   Uploading sfn-tpn v1.0.1 (C:\Users\2014w\Desktop\important and misc\sfn-tpn)
    Uploaded sfn-tpn v1.0.1 to registry `crates-io`
note: waiting for `sfn-tpn v1.0.1` to be available at registry `crates-io`.
You may press ctrl-c to skip waiting; the crate should be available shortly.
    Blocking waiting for file lock on package cache
   Published sfn-tpn v1.0.1 at registry `crates-io`
     Pushing Pushing main, v1.0.1 to origin
Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 20 threads
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 875 bytes | 875.00 KiB/s, done.
Total 8 (delta 5), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (5/5), completed with 3 local objects.
To https://github.com/wade-cheng/sfn-tpn.git
   1794baa..0488a25  main -> main
 * [new tag]         v1.0.1 -> v1.0.1

[epage]

This is unfortunately expected.

When we do a dry run, we do not actually modify files on disk. However, cargo publish only operates on files on disk. Therefore, output from cargo publish is using the current version.

[wade-cheng]

Ah shoot, right, didn't make that connection in my head. It might be helpful to note that in the dry run section of the README. Makes sense either way, thanks!