Add BNB vouching #268
Open
Add BNB vouching #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisang
force-pushed
the
add_bnb_vouching
branch
from
496b3e5 to
d7a0a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the vouching contract on BNB is still not indexed properly, this PR adds manual decoding of the vouching and unvouching events. Same logic has already been applied to Polygon
Note: a
union allis changed tounion distinct. This is needed as Dune has actually partially indexed the vouching events on BNB so the union all resulted in duplicates. This change makes this part more robust.