Fix TypeInitializer issue #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Mar 7, 2024
Collaborator
|
conflict but LGTM |
# Conflicts: # Documentation/Changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1629
OK I guess I need a review here. Changing the tfm of core to only
netstandard2.0fixes the problem. But from my perspective theCoverletToolsPathshould also be resolved properly. The change of the condition forCoverletToolsPathI did in this PR still doesn't seem to work properly. No matter what I do it always point to netstandard2.0But what I think, for e.g.
net6it should point to@MarcoRossignoli @Bertk Am I missing something? Can you help out here?