CBG-4282 silence non-constant format govet error #7140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregns1
previously approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Generally looks good to me and think I agree with implementation choices instead of the use of ("%s", msg). Should we add more to the comments of the new log and NewHTTPError functions to add context of how they should be used when there are no arguments to be passed to format string? Happy to merge as is if you think not necessary so will approve as is.
gregns1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more strict version of govet that is coming in go 1.24 and is already present in golangci-lint 1.24. All of the things flagged were false positives.
NewHTTPErrorto cover when there are no arguments. I could have changed this code toNewHTTPErrorf(status, "%s", msg)but this seemed weird to me and like you wouldn't be sure why you had to use this code and would look this up.FileLogger.logfunction but this could easily uselogf("%s", msg)in the places we are using it likestatsLoggerandconditionalPrintfsince they are called very irregularly.I don't feel strongly about these implementation choices.