CBG-4187: Add stat to track number of assertion failures #7127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
reviewed
Sep 25, 2024
- Enforced 'Assertion failure:' message prefix for searchability. - Swapped warn to error for dev-mode, since we're asking for failures to be reported and want longer-term visibility in collected logs. - Replace dev-mode only stat with the new global stat. - Improve description with instruction for what to do if observed. - Improve godoc comments for AssertfCtx to make it more obvious that it does not do control flow and is up to the caller to do so.
torcolvin
approved these changes
Mar 21, 2025
torcolvin
pushed a commit
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4187
Add stat to track number of assertion failures. Plus more Assertion enhancements:
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/3001/