[3.1.9 backport] CBG-4029 Revocation handling for deleted roles #6958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted roles were not triggering revocation of channels associated with those roles, for two reasons: deleted roles weren't being included in the role set used by RevokedCollectionChannels to identify revoked channels channel history wasn't being updated on deleted roles for non-default collections Deleted roles are now populated on the user object, and a new API added (GetRolesIncDeleted) that returns the union of deleted and non-deleted roles.
gregns1
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted roles were not triggering revocation of channels associated with those roles, for two reasons:
deleted roles weren't being included in the role set used by RevokedCollectionChannels to identify revoked channels channel history wasn't being updated on deleted roles for non-default collections Deleted roles are now populated on the user object, and a new API added (GetRolesIncDeleted) that returns the union of deleted and non-deleted roles.
CBG-4029, backports CBG-4025
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2568/