CBG-2877 allow options to contain db-scoped CORS #6205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
reviewed
Apr 24, 2023
adamcfraser
approved these changes
Apr 24, 2023
torcolvin
added a commit
that referenced
this pull request
May 31, 2023
* CBG-2877 allow options to contain db-scoped CORS * Use pathVars from router.Match to determine keyspace --------- Co-authored-by: adamcfraser <[email protected]>
1 task
adamcfraser
added a commit
that referenced
this pull request
May 31, 2023
… DB basis (#6277) * CBG-2807: Allow databases to override CORS config (#6179) * Don't set db headers unless we auth to DB * Disallow setting max_age on database * CBG-2877 allow options to contain db-scoped CORS (#6205) * CBG-2877 allow options to contain db-scoped CORS * Use pathVars from router.Match to determine keyspace --------- Co-authored-by: adamcfraser <[email protected]> --------- Co-authored-by: adamcfraser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows DB scoped methods to have CORS information.
I considered better ways to solve this with CORS middleware like https://github.com/go-chi/cors (there's a gorilla mux version, but gorilla mux is dead).
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1727/