fix: wait for graceful shutdown before restart #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid failed to initialize database: resource temporarily unavailable
mmsqe
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@mmsqe can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context. |
|
@aljo242 to review sometime |
aljo242
reviewed
Jul 28, 2025
| } | ||
| return nil | ||
|
|
||
| case err := <-errCh: | ||
| if err == http.ErrServerClosed { |
There was a problem hiding this comment.
shouldn't we still return nil from here and not log "closed" as an error?
aljo242
reviewed
Jul 28, 2025
Comment on lines
+229
to
+231
| var app types.Application | ||
| defer func() { | ||
| if err := db.Close(); err != nil { | ||
| svrCtx.Logger.Error("error closing db", "error", err.Error()) | ||
| if app == nil { |
There was a problem hiding this comment.
won't this always be true?
There was a problem hiding this comment.
handle db close if app not initiated when openTraceWriter fail
Line 240 in a995466
aljo242
reviewed
Jul 28, 2025
Comment on lines
+330
to
+332
| var app types.Application | ||
| defer func() { | ||
| if err := db.Close(); err != nil { | ||
| svrCtx.Logger.With("error", err).Error("error closing db") | ||
| if app == nil { |
aljo242
reviewed
Jul 28, 2025
aljo242
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to avoid failed to initialize database: resource temporarily unavailable when node restart without waiting for gracefully shutdown
Closes: #319
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md