Update ESLint Config #407

[Mottoweb]

Hey,

I stumbled upon #407, so i thought i could give it a go for a first good PR.

Let me know if i missed anything.
Things were done:

1. Remove anything lint related from package.json
2. Create .eslintrc.json with same rules.
3. Remove custom rules.

[coveralls]

Coverage remained the same at 91.453% when pulling 637d83b on Mottoweb:eslint-update into fec3883 on coryhouse:master.

[kwelch]

Thanks, I have put in a few comments. I appreciate you taking a stab at this. 👍

[kwelch]

I believe we still want the config to live in package.json. This was done intentionally to reduce errors when the project was copied. See #405

[Mottoweb]

Ok no prob)

[kwelch]

I would expect the import plugin to be listed in plugs. Is it inherited by another?

[Mottoweb]

Could not trace where exactly it is inherited from but, it is.

[kwelch]

I like that we are importing this, I do believe we should find a export preset of rules we can extend here to cover (most or all) of the rules we had previously set.

[Mottoweb]

Then what is the point of removing custom rules and creating dependency on other packages? The very last comment section of the issue #407 suggests a PR that removes custom rules, imports default, or am i wrong?

[kwelch]

@coryhouse & @nickytonline What do you think? I still want to pull it down and run lint a few times and fix to see if it causes any changes.

[nickytonline]

I'm OK with you testing it locally to see if any other changes are required. It's using recommended/defaults for linting, so unless you see something glaring after you test it, I'd say we're probably good to go if Cory's OK with the changes.

[coryhouse]

Linting runs clean for me so PR looks 👍

[nickytonline]

Thanks for the PR @Mottoweb!

[Mottoweb]

Glad to be of help!