Skip to content

Updated setup script #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2016
Merged

Updated setup script #161

merged 3 commits into from
Jun 8, 2016

Conversation

gargrave
Copy link
Contributor

@gargrave gargrave commented Jun 8, 2016

Updated setup tools with the following changes:

  • Reverted back to the ES5-ish syntax, since we don't have the babel packages installed yet when the script is launched (I stayed as faithful as possible to the updates you made to my original version)
  • Replace the existing 'keywords' array with an empty one
  • Validate the name of the package according to npm requirements.

Regarding the validation, I referenced the two links below to try to get the right regex--everything seems solid in my testing, but I am happy to re-visit if you spot any holes. (Basically: URL-friendly, and cannot start with a period or underscore.)

https://github.com/npm/npm/blob/master/doc/files/package.json.md#name
https://stackoverflow.com/questions/695438/safe-characters-for-friendly-url

Let me know if you have any questions or issues.

Thanks,
Gabe

@coveralls
Copy link

coveralls commented Jun 8, 2016

Coverage Status

Coverage remained the same at 98.904% when pulling 8f3d035 on gargrave:master into 4c7d6fb on coryhouse:master.

@coryhouse coryhouse merged commit 4486a8d into coryhouse:master Jun 8, 2016
@coryhouse
Copy link
Owner

Looks great! Thanks so much for the contribution and quick turnaround on the tweaks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants